Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on code coverage test #314

Closed
M-Adoo opened this issue May 8, 2020 · 4 comments
Closed

Build failed on code coverage test #314

M-Adoo opened this issue May 8, 2020 · 4 comments

Comments

@M-Adoo
Copy link

M-Adoo commented May 8, 2020

Build failed in ci env (github action), runs-on ubuntu-latest.

Output:

error: failed to run custom build command for `wayland-client v0.23.6`
##[error]failed to run custom build command for `wayland-client v0.23.6`
Caused by:
  process didn't exit successfully: `/home/runner/work/Holiday/Holiday/target/debug/build/wayland-client-d6fb7ac1cff2eace/build-script-build` (signal: 6, SIGABRT: process abort signal)
--- stdout
cargo:rerun-if-changed=./wayland.xml

warning: build failed, waiting for other jobs to finish...
##[warning]error: build failed
##[error]The process '/usr/share/rust/.cargo/bin/cargo' failed with exit code 101

Run cargo test with below arguments:

CARGO_INCREMENTAL=0
RUSTFLAGS = "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests"

more detail: https://github.com/M-Adoo/Holiday/pull/9/checks?check_run_id=656948665

@elinorbgr
Copy link
Member

Well, that's extremely difficult to guess what causes the build script to SIGABRT like that. wayland-client's build script is just a codegen script, it reads an XML files and generates a rust source file, that's about it.

Given you are using panic=abort, I suspect the build script is actually panicking? If that's the case, that'll be difficult to pinpoint the issue without the panic message and associated stacktrace.

@M-Adoo
Copy link
Author

M-Adoo commented May 8, 2020

Yes. The weird thing is that if I remove panic=abort, it will build successfully.

@elinorbgr
Copy link
Member

Indeed, I can reproduce on rust stable. Just setting RUSTFLAGS="-Cpanic=abort" makes the build script fail. Interesting.

@elinorbgr
Copy link
Member

Ok, this is caused by this : dtolnay/proc-macro2#218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants