Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esp32 Wifi Station Implementation bug #2598

Closed
mr-sven opened this issue Dec 22, 2022 · 1 comment · Fixed by #2600
Closed

Esp32 Wifi Station Implementation bug #2598

mr-sven opened this issue Dec 22, 2022 · 1 comment · Fixed by #2600

Comments

@mr-sven
Copy link
Contributor

mr-sven commented Dec 22, 2022

Hi,
I faced an issue regarding the station implementation.
On Esp32 the esp_wifi_start is not called if the current mode read from storage is already WIFI_MODE_STA or WIFI_MODE_APSTA:

Sming/Sming/Components/Network/Arch/Esp32/Platform/StationImpl.cpp

Line 130 in c3684ab

return; // No change required

Looks like c&p error from the else branch lower.
@slaff
Copy link
Contributor

slaff commented Dec 24, 2022

@mr-sven can you submit a PR with the suggested fix?

@mr-sven mr-sven mentioned this issue Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Esp32 Wifi Station Implementation bugfix mr-sven/Sming
2 participants
@slaff @mr-sven