Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdbstub (not esp-gdbstub) inappropriately named #1547

Closed
riban-bw opened this issue Dec 9, 2018 · 2 comments
Closed

gdbstub (not esp-gdbstub) inappropriately named #1547

riban-bw opened this issue Dec 9, 2018 · 2 comments

Comments

@riban-bw
Copy link
Contributor

riban-bw commented Dec 9, 2018

There is a third-party provided module called, "esp-gdbstub" which implements and interface with gdb debugger. There is also a module called, "gdb" which seems to catch exceptions and print some debug info to serial but does not implement a gdb interface. Naming this "gdb" and describing it within source code as, "A stub to make the ESP8266 debuggable by GDB over the serial port." is misleading and confusing. May I suggest this module be renamed and the description changed to be more appropriate?
Maybe this module should be called, "exception_handler" or similar. I note there is also code, "crash_handler" which may be appropriate to consolidate with this.

@slaff
Copy link
Contributor

slaff commented Dec 10, 2018

"gdb" which seems to catch exceptions and print some debug info to serial but does not implement a gdb interface.

stack_dumper is probably a better name. But I am open to suggestions. Stack dumper should be activated only in non-RELEASE mode.

crash_handler is something that is allowing user-based code to be executed after an exception was raised and do some minimal operations like save it to flash memory or just increase a number. the latter could be used in RELEASE and non-RELEASE mode.

@slaff
Copy link
Contributor

slaff commented Apr 10, 2019

Fixed with the merge of PR #1655.

@slaff slaff closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants