Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abs(coeff2*qqm*term3*term5) #2

Closed
wphu opened this issue Oct 17, 2016 · 2 comments
Closed

abs(coeff2*qqm*term3*term5) #2

wphu opened this issue Oct 17, 2016 · 2 comments
Assignees

Comments

@wphu
Copy link

wphu commented Oct 17, 2016

In line 325 of the file /src/Collisions/Collisions.cpp, should the expression abs(coeff2*qqm*term3*term5) be abs(coeff2*qqm*term3*term5*term5) ?

@mccoys
Copy link
Contributor

mccoys commented Oct 17, 2016

Hi,

This is not an error. In Ref [http://dx.doi.org/10.1063/1.4742167], the corresponding formula indeed shows a squared expression that should be written term5*term5, but this was a typo.

The correct expression has no squared term, as I just verified from the expressions given in the article. The calculation of the minimum deviation angle can be derived from Ref [http://dx.doi.org/10.1143/JPSJ.67.4084] with some effort.

I will make a note about this in the documentation.

Cheers

@wphu
Copy link
Author

wphu commented Oct 17, 2016

OK, thank you very much.

@iltommi iltommi closed this as completed Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants