Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seg fault when 'ionization_electrons' name is mis-matched #11

Closed
JimmyHolloway opened this issue Jul 10, 2017 · 3 comments
Closed

Seg fault when 'ionization_electrons' name is mis-matched #11

JimmyHolloway opened this issue Jul 10, 2017 · 3 comments

Comments

@JimmyHolloway
Copy link

A small issue.

When the name given to 'ionization_electrons' of a species block does not exist or is misspelt, SMILEI segfaults. A check when parsing the input deck would be useful as this kind of error can be missed by the user when double checking the input deck.

Example:

Species(
species_type = 'hydrogen',
atomic_number = 1.0,
ionization_model = 'tunnel',
ionization_electrons = 'ionisede',
etc
)

Species(
species_type = 'Ionisede',
etc
)

Attached is the input deck which exhibits this seg fault.

All the best,
Jimmy.

input.txt

@iltommi iltommi closed this as completed Jul 10, 2017
@iltommi iltommi reopened this Jul 10, 2017
@iltommi
Copy link
Contributor

iltommi commented Jul 10, 2017

Thanks for reporting, I created a branch fix_ionization_undefined that will be merged soon

@JimmyHolloway
Copy link
Author

Great, thanks!

@iltommi
Copy link
Contributor

iltommi commented Aug 3, 2017

Done in d185eea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants