-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual category with installer #395
Comments
I just updated the PR. I was able to reproduce your bug on a "raw" install from Magento sources when having setup files which were creating categories. You are right, adding a sequence to elasticsuite modules is not enough, so I added a cleaning of EAV cache manually after creating the attributes, since Magento does not do it when using addAttribute. Feel free to test it and give us comments. BR |
@romainruaud I've added |
@madonzy please consider testing the fix by switching to my branch and not implementing your own fix by inspirating with mine. My branch is working when launching Magento install based on one of our project containing categories creation in Setup files. This was crashing before my fix with the same error as yours. So I think I fixed the point. Let me know, |
@romainruaud how can I switch to "your" branch? What exactly do you mean? Please provide some steps, because I'm not really understand you. |
You could do either :
Then try again to run your bin/magento setup:install and tell me if this does solve the issue. Regards, |
@romainruaud Still not clear... What is your branch? What did you do? Where? Is it official fix? maybe I can just update elsticsuite with a composer? |
@romainruaud I did second way and it works!! Thank you!! |
Fine ! You'll be able to switch back to our 2.3.x branch once @afoucret will have merged this. Bes regards |
Fixed by PR #397 . Please wait for the next minor 2.3 release or feel free to use the 2.3.x branch while waiting for it. Best regards, |
I want to install virtual category with an installer (InstallData.php). (Only while installing Magento)
Preconditions
Linux debian-8 3.16.0-4-amd64 #1 SMP Debian 3.16.39-1+deb8u2 (2017-03-07) x86_64 GNU/Linux
Magento Version: 2.1.4 CE
ElasticSuite Version : 2.3.4
Environment : default
Steps to reproduce
Expected result
All modules installed successfully
Actual result
I have an error:
If I don't add the sequence, then the category is added but fields is_virtual_category and virtual_category_root aren't set. I add the category like that:
The text was updated successfully, but these errors were encountered: