-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC : Search products by SKU #100
Comments
Because SKU is not mapped correctly! Compared to attribute sprc_sku: "sprc_sku_code" : { Do you see what is missing? |
I believe the built-in indices that are not user-added are supposed to be picked up by an xml file but they are not being processed could be ElasticsuiteCore/etc/elasticsuite_indices.xml you can force all fields to be searchable by modifying (ghetto-fix): in module-elasticsuite-core/Index/Mapping/Field.php Change: to: which will default all fields not specified to be is_searchable ! I am not sure if the other fields could be tweaked to perform better SKU searching but this tweak does work temporarily! |
My proposal of implementation : 1st step :
This will prevent fields using this analyzer to be splitted between word and number, hyphens ...
2nd step :
=> Tested on SKU attribute, this is working fine on Luma catalog, with SKUs being something like "MH09". Still need to test for EAN13 but should also work. @afoucret feel free to tell me what you think about it. |
This one is solved by PR #300. |
@afoucret i see that this PR is for 2.4.x but do you have a fix fro current version 2.3.x? |
Can we use 2.4.0 already in production? When will 2.4.0 be available? |
@PieterCappelle the release date of 2.4.0 is "soon". We are currently finishing our testing procedures internally, having updated the README, cleaning the documentation etc ... You can consider it is actually in RC state, so feel free to use it in production (but with caution) if you want. But beware, 2.4.0 version will be supporting only Magento 2.2. This is especially due to the update of their unit testing tools, which does not allow to run properly the unit testing on Magento 2.1 with Elasticsuite 2.4. Best regards. |
Searches by SKU currently return 0 results on our Magento 2.1 instances with Elasticsuite 2.2.
Searching for names or other custom attribute values seem to return the correct results.
The "Use in search" configuration is currently activated on our "sku" product attribute, but it seems to have no effect on our results.
The same problem can be observed on the demo store (http://demo.magento-elastic-suite.io/), although I don't know if the SKU attribute was configured to be used in searches there.
Our current configuration is :
The text was updated successfully, but these errors were encountered: