Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book page numbers no longer render #218

Open
KnightMiner opened this issue Nov 30, 2024 · 1 comment
Open

Book page numbers no longer render #218

KnightMiner opened this issue Nov 30, 2024 · 1 comment
Labels
1.18 Affects Minecraft versions 1.18 1.19 bug resolved Fixed in code, not yet released

Comments

@KnightMiner
Copy link
Member

During the GUI rewrites in 1.18, seems pages no longer render page numbers. Apparently AppearanceData.renderPageNumbers is simply never used.

Comparison screenshots between 1.16 and 1.20 are attached below.
page_6
page_6
@KnightMiner KnightMiner added 1.18 Affects Minecraft versions 1.18 1.19 1.20 bug labels Nov 30, 2024
@KnightMiner KnightMiner added the resolved Fixed in code, not yet released label Dec 10, 2024
@KnightMiner
Copy link
Member Author

Fixed in 1.9.54 for 1.18.2 via ab846c7.

Also fixed in an upcoming build for 1.19.2 via f86893e. Will leave open until its released on 1.19.2

@KnightMiner KnightMiner removed the 1.20 label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.18 Affects Minecraft versions 1.18 1.19 bug resolved Fixed in code, not yet released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnightMiner