Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem With Mantle #213

Closed
JonathanMarulanda opened this issue Aug 19, 2024 · 6 comments
Closed

Problem With Mantle #213

JonathanMarulanda opened this issue Aug 19, 2024 · 6 comments
Labels
1.18 Affects Minecraft versions 1.18 can't fix compatibility

Comments

@JonathanMarulanda
Copy link

crash-2024-08-19_01.58.05-client.txt

@KnightMiner
Copy link
Member

You need to provide more info than just a crash report. Explain what you were doing when the crash happened, was it on game start? world load? in a particular inventory?

Also, can you reproduce the crash with fewer mods? Try narrowing it down to just Mantle an whatever mods you have that depend on Mantle.

@KnightMiner KnightMiner added the not enough information Insufficient information is provided in the issue to accurately respond label Aug 19, 2024
@JonathanMarulanda
Copy link
Author

This crash was in the game, I dont have any problem with world loading and the game start, Im using Tinkers Construct with Chipped.

Im tried to reproduce the crash and yeah, looks like the same: (I tried with fewer mods by the way)
crash-2024-08-19_13.15.18-client.txt

The game crash when Im in creative mode in the inventory, "Tinker's Smeltery", I just had open that and then the game crash.
In addition the game crash when im walking in the world.

2024-08-19.13-12-39.mp4

Thank you for your time.

@KnightMiner
Copy link
Member

You still have dozens of mods. Find a minimal list of mods to reproduce this crash. Given no one besides you has experienced it before, its a mod conflict, and I am not sure which mod is to blame.

Try removing rendering mods to start, the name Brute force Rendering Culling sounds very suspect. memoryleakfix could also be to blame if its removing data we rely upon. Need to narrow down why it crashes for you and not for other people.

@JonathanMarulanda
Copy link
Author

JonathanMarulanda commented Aug 19, 2024

Everything is fine now!

It seems the conflict was with "REdirector" and "Mantle"; after triying and triying the crash doesn't appear again.

I never tought that is going to be redirector, I tried with every render mod (Embeddium, Memory Leak, Entity Culling, Ferritecore, ModernFix etc.), and seems redirector changes some values of the minecraft code.

So thats it, Thanks for you help.

@KnightMiner
Copy link
Member

Curious, that mod description does not seem to suggest any relationship to this crash report. I'll look into it further when I have a chance to see if there is anything we can do to recover from this error on our side or if they just left the game in an unrecoverable state. Unfortunately, that mod is closed source so I cannot tell what they are actually doing.

@KnightMiner KnightMiner added 1.18 Affects Minecraft versions 1.18 compatibility and removed not enough information Insufficient information is provided in the issue to accurately respond labels Aug 20, 2024
@KnightMiner
Copy link
Member

Looked into this a bit more, code in question is iterating the map of faces in a block, and intentionally only iterates faces that contain data. Means someone inserted null as a face in a block. Looking further, such a null would crash quite a few spots in standard block model code so no reason for us to check for it.

Figure out which mod is so badly breaking block models and report it to them.

@KnightMiner KnightMiner closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.18 Affects Minecraft versions 1.18 can't fix compatibility
Projects
None yet
Development

No branches or pull requests

2 participants