Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes for 1.19 #194

Closed
4 of 5 tasks
KnightMiner opened this issue Jan 17, 2023 · 1 comment
Closed
4 of 5 tasks

Breaking changes for 1.19 #194

KnightMiner opened this issue Jan 17, 2023 · 1 comment
Labels
1.19

Comments

@KnightMiner
Copy link
Member

KnightMiner commented Jan 17, 2023 •
edited
Loading

This issue describes things to change for the 1.19 port, as I have pending breaking changes. Will be updating this periodically as I remember more things.

  • Cleanup methods on SimpleBlockModel, then have ColoredBlockModel extend it. Will make it easier to support in all custom models
  • Fully migrate JSON predicates from Tinkers' Construct
  • Clean up model data usage, getModelData is intended to return a new instance instead of a cached instance as forge will cache it for me. refreshModelData will alert forge to call getModelData again to get the new instance
  • Rename keys on fluid ingredient for consistency with outputs/item ingredients (see Inconsistent keys for input and output on alloying recipes #203)

Changes that would be good

  • Migrate multi-module UIs to widgets
@SlimeKnights SlimeKnights locked and limited conversation to collaborators Jan 17, 2023
@KnightMiner
Copy link
Member Author

I'll get around to the UI migration one of these days. Rest is done, so this issue served its purpose.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
1.19
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnightMiner