Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Scene tiles intersect Caspian Sea #91

Open
jonaraphael opened this issue Aug 8, 2023 · 1 comment
Open

Error: Scene tiles intersect Caspian Sea #91

jonaraphael opened this issue Aug 8, 2023 · 1 comment

Comments

@jonaraphael
Copy link
Collaborator

jonaraphael commented Aug 8, 2023

IndexError: list index out of range at ._orchestrate ( /app/cerulean_cloud/cloud_run_orchestrator/handler.py:349 )
Happens about 8 times / day.

Our custom code in cerulean-cloud/cerulean_cloud/cloud_function_scene_relevancy/main.py considers the Caspian Sea as a body of water that we want to predict on. That means that Scenes touching the Caspian are passed into the orchestrator.

However, the code that determines which tiles to pass into the predict endpoint uses globe.is_ocean(), which is 3rd party code that excludes the Caspian. This results in a zero-length list of tiles, which is a case that is not handled gracefully, causing this error.

Options for resolution:

  1. Handle the error gracefully. This means the Caspian Sea is not processed.
  2. Remove the Caspian Sea from our scene_relevancy function. This means the Caspian Sea is not processed.
  3. Edit the globe.is_ocean() code to return True for tiles over the Caspian.
  4. Replace the globe.is_ocean() code to use our scene_relevancy function logic, making them consistent.

I prefer option 4.

@jonaraphael
Copy link
Collaborator Author

At the same time, could unify the third application as well: crop inferences to ignore those that intersect land...
https://skytruth.atlassian.net/browse/TECH-741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant