Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow the user to submit if they have not closed a polygon. #25

Closed
Yolandeezy opened this issue Jan 29, 2015 · 2 comments
Closed

Don't allow the user to submit if they have not closed a polygon. #25

Yolandeezy opened this issue Jan 29, 2015 · 2 comments
Assignees
@redhog

Comments

@Yolandeezy
Copy link
Contributor

If the user clicks twice on the map to start drawing a polygon, does not double-click to close, and clicks done then the subsequent task-run does not contain any geometry but has a selection of done.

The user should not be allowed to submit a task if there is an open geometry. Instead they should be presented with an error stating they have to close polygons before submitting.
@Yolandeezy Yolandeezy added this to the Fix Now milestone Jan 29, 2015
@geowurster geowurster changed the title Create error message for incomplete polygons Don't allow the user to submit if they have not closed Create error message for incomplete polygons Jan 29, 2015
@geowurster geowurster changed the title Don't allow the user to submit if they have not closed Create error message for incomplete polygons Don't allow the user to submit if they have not closed a polygon. Jan 29, 2015
@redhog
Copy link

redhog commented Jan 30, 2015

Done in SkyTruth/pybossa_tools@c1b41fb

@redhog
Copy link

redhog commented Jan 30, 2015

It's impossible / hard to detect an unfinished geometry, http://dev.openlayers.org/docs/files/OpenLayers/Control/DrawFeature-js.html does not seem to have any api for that, so right now I'm just detecting there being at least one finished geometry. Hope that's good enough...

@redhog redhog closed this as completed Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redhog redhog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redhog @Yolandeezy