Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inventory material aliases in multiple non inventory material aliases #5586

Open
1 task done
TheLimeGlass opened this issue Apr 7, 2023 · 2 comments
Open
1 task done
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@TheLimeGlass
Copy link
Contributor

Suggestion

There is currently an issue where oak sign would pick either a oak wall sign or a oak floor sign. If it picks the oak wall sign, no item will be displayed in the inventory as a wall sign cannot be displayed in an inventory. This is not an aliases issue as oak sign should represent either oak floor or oak wall signs for proper comparison of block types.

We should implement some sorta system to allow oak sign to always use the oak floor sign in a gui.

Why?

The item isn't displaying in the inventories

Other

Work arounds are instead of defining oak sign use oak floor sign when adding to the inventory.

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Apr 7, 2023
@TheLimeGlass TheLimeGlass changed the title Support inventory and block types in aliases Support inventory material types in multiple non inventory aliases Apr 7, 2023
@TheLimeGlass TheLimeGlass changed the title Support inventory material types in multiple non inventory aliases Support inventory material aliases in multiple non inventory material aliases Apr 7, 2023
@TheLimeGlass TheLimeGlass added priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). and removed priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Jun 4, 2023
@Fusezion
Copy link
Contributor

Fusezion commented Jun 7, 2024

Thinking about making a mock of a test fix/change for this but I'm not sure what's the best way to do so, as I can't just rip them out of getRandom and getAll as they still have uses to exist inside it, would it be better to add some addition method and if so what would the name even be?

@APickledWalrus
Copy link
Member

some sort of getRandomItem might suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

3 participants