From 9a522a56c6d060e9d3dcd97663b0f6b8cfe78d50 Mon Sep 17 00:00:00 2001 From: Ross Keenan Date: Thu, 6 Jan 2022 11:27:16 +0200 Subject: [PATCH] fix(TagNote): :bug: Allow blank default tagNoteFiled --- main.js | 6 +++--- src/BreadcrumbsSettingTab.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/main.js b/main.js index 924ad72b..c62d2d40 100644 --- a/main.js +++ b/main.js @@ -25564,11 +25564,11 @@ class BCSettingTab extends require$$0.PluginSettingTab { const tagNoteDetails = subDetails("Tag Notes", alternativeHierarchyDetails); new require$$0.Setting(tagNoteDetails) .setName("Default Tag Note Field") - .setDesc(fragWithHTML("By default, tag notes use the first field in your hierarchies (usually an field). Choose a different one to use by default, without having to specify BC-tag-note-field: {field}.")) + .setDesc(fragWithHTML("By default, tag notes use the first field in your hierarchies (usually an field). Choose a different one to use by default, without having to specify BC-tag-note-field: {field}.
If you don't want to choose a default, select the blank option at the bottom of the list.")) .addDropdown((dd) => { const options = {}; getFields(settings.userHiers).forEach((field) => (options[field] = field)); - dd.addOptions(options); + dd.addOptions(Object.assign(options, { "": "" })); dd.onChange(async (field) => { settings.tagNoteField = field; await plugin.saveSettings(); @@ -51791,6 +51791,7 @@ class BCPlugin extends require$$0.Plugin { console.log("loading breadcrumbs plugin"); await this.loadSettings(); const { settings } = this; + this.addSettingTab(new BCSettingTab(this.app, this)); if (typeof settings.debugMode === "boolean") { settings.debugMode = settings.debugMode ? "DEBUG" : "WARN"; await this.saveSettings(); @@ -52112,7 +52113,6 @@ class BCPlugin extends require$$0.Plugin { }); }); this.addRibbonIcon(addFeatherIcon("tv"), "Breadcrumbs Visualisation", () => new VisModal(this.app, this).open()); - this.addSettingTab(new BCSettingTab(this.app, this)); } getActiveTYPEView(type) { const { constructor } = this.VIEWS.find((view) => view.type === type); diff --git a/src/BreadcrumbsSettingTab.ts b/src/BreadcrumbsSettingTab.ts index 8776920c..2faee616 100644 --- a/src/BreadcrumbsSettingTab.ts +++ b/src/BreadcrumbsSettingTab.ts @@ -729,7 +729,7 @@ export class BCSettingTab extends PluginSettingTab { .setName("Default Tag Note Field") .setDesc( fragWithHTML( - "By default, tag notes use the first field in your hierarchies (usually an field). Choose a different one to use by default, without having to specify BC-tag-note-field: {field}." + "By default, tag notes use the first field in your hierarchies (usually an field). Choose a different one to use by default, without having to specify BC-tag-note-field: {field}.
If you don't want to choose a default, select the blank option at the bottom of the list." ) ) .addDropdown((dd: DropdownComponent) => { @@ -737,7 +737,7 @@ export class BCSettingTab extends PluginSettingTab { getFields(settings.userHiers).forEach( (field) => (options[field] = field) ); - dd.addOptions(options); + dd.addOptions(Object.assign(options, { "": "" })); dd.onChange(async (field) => { settings.tagNoteField = field; await plugin.saveSettings();