From 59d08f79a4c7cba34a6b12bdce19e2c9c24477f4 Mon Sep 17 00:00:00 2001 From: Harel Moshe Date: Mon, 22 Mar 2021 14:45:00 +0200 Subject: [PATCH 1/2] Upgrade nock version to mitigate https://github.com/nock/nock/issues/1239 --- package.json | 2 +- test/mocker/interactive-buttons.spec.js | 2 +- test/mocker/slash-commands.spec.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index c3ace9a..f15b558 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ }, "dependencies": { "express": "^4.14.0", - "nock": "^9.0.2", + "nock": "^13.0.0", "qs": "^6.3.0", "request": "^2.79.0", "winston": "^2.3.0", diff --git a/test/mocker/interactive-buttons.spec.js b/test/mocker/interactive-buttons.spec.js index 35ad084..a957df5 100644 --- a/test/mocker/interactive-buttons.spec.js +++ b/test/mocker/interactive-buttons.spec.js @@ -67,7 +67,7 @@ describe('mocker: interactive buttons', function () { customResponsesMock.get.reset() customResponsesMock.set.reset() customResponsesMock.reset.reset() - customResponsesMock.get.returns(200, 'OK', {}) + customResponsesMock.get.returns([200, 'OK', {}]) loggerMock.error.reset() loggerMock.info.reset() diff --git a/test/mocker/slash-commands.spec.js b/test/mocker/slash-commands.spec.js index d4692ec..74593c5 100644 --- a/test/mocker/slash-commands.spec.js +++ b/test/mocker/slash-commands.spec.js @@ -67,7 +67,7 @@ describe('mocker: slash commands', function () { customResponsesMock.get.reset() customResponsesMock.set.reset() customResponsesMock.reset.reset() - customResponsesMock.get.returns(200, 'OK', {}) + customResponsesMock.get.returns([200, 'OK', {}]) loggerMock.error.reset() loggerMock.info.reset() From c1a1d300842ba8eff6f391f8ca8ba27abd49ad7c Mon Sep 17 00:00:00 2001 From: Harel Moshe Date: Mon, 22 Mar 2021 15:08:57 +0200 Subject: [PATCH 2/2] Update minimal node version --- .travis.yml | 3 +-- package.json | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index c648bd7..32b8a88 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,8 +2,7 @@ sudo: false language: node_js # test historically supported versions, lts, and current stable version node_js: - - "6" - - "8" + - "10" - "lts/*" - "node" install: npm install diff --git a/package.json b/package.json index f15b558..8abc618 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "author": "", "license": "MIT", "engines": { - "node": ">=6.0.0" + "node": ">=10.0.0" }, "repository": { "type": "git",