add --cookie option
#224
Closed
add --cookie option
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skallwar
requested changes
Jun 26, 2023
Skallwar
reviewed
Jun 26, 2023
| @@ -68,8 +70,12 @@ impl Downloader { | |||
| auth_map.insert(host, (username, password)); | |||
| } | |||
|
|
|||
| let mut headers = HeaderMap::new(); | |||
| headers.insert(COOKIE, HeaderValue::from_str(cookie).unwrap()); | |||
There was a problem hiding this comment.
I fear this will not work over multiple domains, as you would always give the same cookies without taking into consideration the domains. What if 2 domains want a cookie named test?
If you have time (and want to go further with this), have a look there:
- https://docs.rs/reqwest/latest/reqwest/cookie/struct.Jar.html#method.add_cookie_str
- https://docs.rs/reqwest/latest/reqwest/struct.ClientBuilder.html#method.cookie_provider
In any case this is better than what we have now so I will take this, with the modifications or not. Let me know
Signed-off-by: Esteban Blanc <[email protected]>
Signed-off-by: Esteban Blanc <[email protected]>
Merged
|
Replaced by #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple pull request that adds a
--cookieflag that allows setting a cookie header in the formatkey1=value;key2=valueSolves #67