Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-generic Image.Load should decode Jpeg into Image<Rgb24> #1410

Closed
antonfirsov opened this issue Nov 2, 2020 · 0 comments · Fixed by #1773
Closed

Non-generic Image.Load should decode Jpeg into Image<Rgb24> #1410

antonfirsov opened this issue Nov 2, 2020 · 0 comments · Fixed by #1773

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Nov 2, 2020

Prerequsite: #1354

  • Top gain: reduced memory footprint
  • There will be a noticeable LoadResizeSave speed regression on 2.1 and Framework (no SIMD for shuffles), but I hope the ROTR / ROTL path will keep it in an acceptable range.
  • On 3.1 and .NET 5 the LoadResizeSave speed regression should be negligible thanks to the SIMD path in 3 <==> 4 Channel Shuffling with Hardware Intrinsics #1409
  • Introduce PixelTypeInfo.HasAlpha #1396 combined with omitting premultipication for Rgb24 will cancel out these regressions, bringing noticeable speedup on 3.1 and .NET 5. We may want to consider milestoning that issue to 1.1.0
@antonfirsov antonfirsov added this to the 1.1.0 milestone Nov 2, 2020
@antonfirsov antonfirsov changed the title Non-generic Image.Load should decode into Image<Rgb24> Non-generic Image.Load should decode Jpeg into Image<Rgb24> Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants