Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account number wrong on German IBAN (only 9 digits) #550

Open
magnattic opened this issue May 27, 2024 · 0 comments · May be fixed by #556
Open

Account number wrong on German IBAN (only 9 digits) #550

magnattic opened this issue May 27, 2024 · 0 comments · May be fixed by #556
Assignees
Labels

Comments

@magnattic
Copy link

magnattic commented May 27, 2024

Describe the bug
When running extractIBAN, the extracted account number for German IBANs is only 9 digits when it should be 10.

Example IBANs:

  • DE22 1001 0050 0123 4567 89 -> produces '123456789'
  • DE40 9263 7373 1623 4311 42 -> produces '623431142'

Official docs from the Deutsche Bundesbank:
image

To Reproduce
Run this test:

import { extractIBAN } from 'ibantools';

describe('ibantools', () => {
  it('just works, () => {
    expect(extractIBAN('DE22 1001 0050 0123 4567 89').accountNumber).toBe(
      '0123456789'
    );
  });
});

Expected behavior
The test should pass.

Environment:
ibantools v4.5.1

@Simplify Simplify added the bug label Jun 4, 2024
@Simplify Simplify self-assigned this Jun 4, 2024
Simplify added a commit that referenced this issue Jun 4, 2024
@Simplify Simplify linked a pull request Jun 4, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants