Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for MagicProvider #40

Open
alitonia opened this issue Oct 26, 2020 · 0 comments
Open

Add test for MagicProvider #40

alitonia opened this issue Oct 26, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alitonia
Copy link
Contributor

🚀 feature request

Description

A clear and concise description of the problem or missing capability...

Currently, MagicProvider is asynchronously updated by ThemeProviderComponent.
However, it is lacking test to make sure the component will work when the returned data is different.

ThemeProviderComponent is getting data from getAsyncTheme, which is a placeholder till we finish the network part.

Describe the solution you'd like

If you have a solution in mind, please describe it.

Write a test to cover the MagicProvider
Some cases need to cover: data return empty, data override defaultTheme, data add new fields
@alitonia alitonia added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alitonia