Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for prom-client >= 13 #72

Closed
woodb opened this issue Jan 29, 2021 · 2 comments · Fixed by #143
Closed

Support for prom-client >= 13 #72

woodb opened this issue Jan 29, 2021 · 2 comments · Fixed by #143

Comments

@woodb
Copy link

woodb commented Jan 29, 2021

Last month, prom-client released v13.0.0, which includes some breaking changes.

With (what appears to be) only a single release of a 12.x version of the prom-client lib, it looks like active development/maintenance of the prom-client library is going to continue as 13.x (or greater).

In order to keep things up-to-date/maintained, it would be great if we could add support for prom-client >= 13 to this project.
@SimenB
Copy link
Owner

SimenB commented Jan 30, 2021

prom-client@12 includes support for GC stats, so I don't think this module is needed anymore, ref siimon/prom-client#361 (comment)

@dapplion dapplion mentioned this issue Mar 28, 2021
Closed
@SimenB SimenB linked a pull request Sep 6, 2023 that will close this issue
feat: add prom-client 13 and 14 to peer deps #143
Merged
@SimenB
Copy link
Owner

SimenB commented Sep 6, 2023

https://github.com/SimenB/node-prometheus-gc-stats/releases/tag/v0.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add prom-client 13 and 14 to peer deps SimenB/node-prometheus-gc-stats
2 participants
@SimenB @woodb