Skip to content

Commit

Permalink
fix: upgrade dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
SimenB committed Jan 27, 2019
1 parent 08ace07 commit 60c10f0
Show file tree
Hide file tree
Showing 4 changed files with 1,700 additions and 1,896 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"homepage": "https://github.com/SimenB/add-asset-html-webpack-plugin#readme",
"dependencies": {
"globby": "^8.0.0",
"globby": "^9.0.0",
"micromatch": "^3.1.3",
"p-each-series": "^1.0.0"
},
Expand All @@ -48,7 +48,7 @@
"@babel/plugin-transform-modules-commonjs": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"babel-core": "^7.0.0-bridge.0",
"babel-jest": "^23.6.0",
"babel-jest": "^24.0.0",
"babel-plugin-add-module-exports": "^1.0.0",
"classnames": "^2.2.5",
"del-cli": "^1.1.0",
Expand All @@ -57,7 +57,7 @@
"eslint_d": "^7.1.0",
"html-webpack-plugin": "^4.0.0-0",
"husky": "^1.0.1",
"jest": "^23.6.0",
"jest": "^24.0.0",
"jest-watch-typeahead": "^0.2.0",
"licensor": "^4.0.0",
"lint-staged": "^7.0.0",
Expand Down
9 changes: 4 additions & 5 deletions src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,10 @@ export async function handleUrl(assets) {
const globbyAssets = [];
const normalAssets = [];
// if filepath is null or undefined, just bubble up.
assets.forEach(
asset =>
asset.filepath && globby.hasMagic(asset.filepath)
? globbyAssets.push(asset)
: normalAssets.push(asset),
assets.forEach(asset =>
asset.filepath && globby.hasMagic(asset.filepath)
? globbyAssets.push(asset)
: normalAssets.push(asset),
);
const ret = [];
await Promise.all(
Expand Down
2 changes: 1 addition & 1 deletion test.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ test('should used passed in publicPath', async () => {
});

// TODO: No idea what this does, actually... Coverage currently hits it, but the logic is untested.
test.skip('should handle missing `publicPath`', () => {});
test.todo('should handle missing `publicPath`');

test('should add file missing "/" to public path', async () => {
const compilation = { options: { output: { publicPath: 'vendor' } } };
Expand Down
Loading

0 comments on commit 60c10f0

Please sign in to comment.