Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Linear Elastic Model and Remove Redundancy #316

Open
1 task done
divyaadil23 opened this issue Dec 16, 2024 · 2 comments
Open
1 task done

Test Linear Elastic Model and Remove Redundancy #316

divyaadil23 opened this issue Dec 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@divyaadil23
Copy link
Contributor

divyaadil23 commented Dec 16, 2024

Problem

There seem to be 2 options for the linear elastic model - phys_lElas and stIso_LS. Neither of them have any test cases.

Solution

Look at how the two models are different, and combine them into a single model. Add unit tests and/or integration tests.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@divyaadil23 divyaadil23 added the enhancement New feature or request label Dec 16, 2024
@ktbolt
Copy link
Collaborator

ktbolt commented Dec 17, 2024

@divyaadil23 phys_lElas is an equation type, stIso_LS is a material model.

There are tests here for phys_lElas.

I believe that the stIso_LS material model is used for the mesh equation type.

@mrp089
Copy link
Member

mrp089 commented Dec 18, 2024

The linear elasticity test cases are still missing in #95 and stIso_LS is not covered. It would be nice if we could finally close that. @divyaadil23 do you want to add those as a first step?

As @ktbolt said, we use a linear elastic material for mesh deformation in ALE-FSI. It looks like the mesh equation type uses its own linear elastic material model that is covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants