Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeartBeat.MarkConnection(this) called twice per Send(..) in ForeverTransport #333

Closed
KrzysFR opened this issue Apr 24, 2012 · 1 comment
Closed
Assignees
Milestone

Comments

@KrzysFR
Copy link
Contributor

KrzysFR commented Apr 24, 2012

The method Send(PersitentResponse) in base class ForeverTransport calls HeartBeat.MarkConnection(this) then calls OnSending(data) that will also call MarkConnection(this). It will be called twice per send.

All classes deriving from ForeverTransport (ForeverFrameTransport, and ServerSentEventsTransport) overide Send and do their own thing, so that would only happen for custom transport classes.

@ghost ghost assigned davidfowl Jun 20, 2012
@davidfowl
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants