Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing brackets in the example #34

Closed
wants to merge 2 commits into from
Closed

Add missing brackets in the example #34

wants to merge 2 commits into from

Conversation

FredericGuilbault
Copy link

No description provided.

@tkurki
Copy link
Member

tkurki commented Mar 25, 2019

That configuration snippet is valid (well, as valid as a snippet is) but you have pipedProvider that consists of a single serialport provider, meaning that there is nothing that converts the serialport input to Signal K, which 99.9% of the time is incorrect.

The README dates from the time with SK server having no admin ui to speak of and inputs were configured by editing settings files.

Now we have the admin ui, so a better example here would be a screen shot of the relevant part of it. Care to make one?

@FredericGuilbault
Copy link
Author

Ah oui,
I get it now. I must say it's confusing ...to the point I tought it was an error lol.

But then, I have read #11
And as I understand, this snippet does not reflect intended use of signalk-to-nmea. This plugin emit tcp on port 10110. But the snippet seem to be about producing a fake serial device/port in /dev/. There is an other plugin for serial devices If I remember.

Prior to updating the README I just want to make sure about that. Then ill make a proposal with an updated screen shot.

@tkurki
Copy link
Member

tkurki commented Mar 26, 2019

The configuration snippet is about the case where you want to output the sentences to a serial connection. The plugin itself only output events, that are used by default by tcp connection on port 10110. If you want serial output you need to configure the serial to handle the event as well.

@FredericGuilbault
Copy link
Author

FredericGuilbault commented Mar 29, 2019

Im still a bit confused, so Im not sure if I got this right. Tell me if something need to be changed. IDC making an other revision.

@tkurki
Copy link
Member

tkurki commented Aug 20, 2019

I updated the readme in 001c279.

@tkurki tkurki closed this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants