Fix: Clear destination on empty or invalid position received via NMEA #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtPoint.position value when stream source is the cmdSource.
tkurki
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Did I understand it correctly: after this change not only empty destination fields but also invalid destination coordinate values received from NMEA data will clear the destination?
If that is so then the change is ok, but I think we should change the PR title & description, as NMEA is not mentioned at all and imho people are more interested in how the server's behavior changes, not how things work internally.
panaaj
changed the title
This is correct. |
naugehyde
pushed a commit
to naugehyde/signalk-server-nextgen
that referenced
this pull request
Dec 14, 2024
…xtPoint.position value when stream source is the cmdSource. (SignalK#1844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the improved position validity test (#1840) to determine when to clear
course.nextPoint.positionvalue.Ensures the same validity test is used for both setting and clearing destination position.