Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow third party apps to integrate with security #560

Merged
merged 2 commits into from
Jun 23, 2018

Conversation

sbender9
Copy link
Member

Specifically done to enable security for node

@sbender9 sbender9 changed the title feature: allow third party apps to integrate with security [WIP] feature: allow third party apps to integrate with security Jun 20, 2018
@sbender9
Copy link
Member Author

Having issues. I can't git this to work with our security middleware...

@sbender9 sbender9 changed the title [WIP] feature: allow third party apps to integrate with security feature: allow third party apps to integrate with security Jun 21, 2018
@sbender9
Copy link
Member Author

@tkurki I'd like to go ahead and merge this. I have not been able to get things to work by just using our security middleware and having to login again to node-red is better than having no security at all.

@tkurki
Copy link
Member

tkurki commented Jun 21, 2018

Ok. But then just cherry pick 3ee4060? I can take a look at this over the weekend.

@sbender9 sbender9 force-pushed the node-red-security branch from c962135 to 0482ed5 Compare June 21, 2018 20:04
Specifically done to enable security for node red
@sbender9 sbender9 force-pushed the node-red-security branch from 0482ed5 to 6769d87 Compare June 21, 2018 20:50
@tkurki
Copy link
Member

tkurki commented Jun 22, 2018

  1) Security
       websockets acls work:
     Uncaught TypeError: Cannot read property 'id' of undefined
      at update.values.update.values.map.valuePath (lib/tokensecurity.js:439:22)
      at Array.map (<anonymous>)
      at delta.updates.delta.updates.map.update (lib/tokensecurity.js:437:14)
      at Array.map (<anonymous>)
      at Object.strategy.filterReadDelta (lib/tokensecurity.js:435:10)
      at aclFilter (lib/interfaces/ws.js:117:45)
      at onChange (lib/interfaces/ws.js:223:15)

@sbender9
Copy link
Member Author

Yeah, I guess maybe running the tests first would have been a good idea...

@tkurki tkurki merged commit e7ba9b5 into master Jun 23, 2018
@tkurki tkurki deleted the node-red-security branch October 29, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants