chore: create @signalk/plugin-config package within same git project #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move makes it easier for this github repo to be used as a monorepo and for plugin-config to be its own npm module.
Since plugin-config is its own module it should have its own ignore files. This removes old rules from root and adds them to plugin-config directory.
Need to change way we get path of the plugin-config assets. Using get-installed-path makes it easy. Server now works with plugin-config as package.
webmasterkai
changed the title
I forgot to leave a comment of what the function does.
|
This is ready to review. Server changed the way we get the public path of for plugin-config assets. Using new get-installed-path dependency makes it easy. Server now works with |
Script to compile main.js before publishing npm module.
When plugin-config is a package the build process is not required.
|
References to the plugin-config build process have been removed. As a package it is no longer required. |
… into packages-plugin-config
|
I don't think we need this get code. You can just use app.config.appPath |
|
Where would we use |
|
On second thought. Lets keep it. |
|
Can you come up with a better title. Something will make more sense to a layman in the CHANGELOG |
webmasterkai
changed the title
Do not want to install extra packages when folks npm install the plugin-config package.
Needed to make npm happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
plugin-configto/packages/plugin-config. This makes it easier for this github repo to be used as a "monorepo" and forplugin-configto be its ownnpmmodule.Since
plugin-configis its own module it should have its own ignore files. This removes old rules from the root and adds them topackages/plugin-configdirectory.