fix: make app.savePluginOptions work from plugin #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enabled and enableLogging flags that are managed by the server and not part of the plugin's config schema were not handled when calling savePluginOptions from a plugin. This changes the logic so that if a plugin calls savePluginOptions the values for these two properties are retrieved from the file system and the plugin config is saved in the proper structure, with the plugin's own data nested under 'configuration' property.
tkurki
force-pushed
the
fix-savePluginOptions
branch
from
8ddfe4e to
034e2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enabled and enableLogging flags that are managed
by the server and not part of the plugin's config
schema were not handled when calling savePluginOptions
from a plugin. This changes the logic
so that if a plugin calls savePluginOptions the
values for these two properties are retrieved from
the file system and the plugin config is saved
in the proper structure, with the plugin's own data
nested under 'configuration' property.