From 71f32f03a8381f52b917f225b36c240883dde320 Mon Sep 17 00:00:00 2001 From: vikrantgupta25 Date: Wed, 4 Dec 2024 11:05:26 +0530 Subject: [PATCH] chore: comments for side nav issues --- frontend/src/container/SideNav/SideNav.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/frontend/src/container/SideNav/SideNav.tsx b/frontend/src/container/SideNav/SideNav.tsx index f3bdbe0870..e2eb1189df 100644 --- a/frontend/src/container/SideNav/SideNav.tsx +++ b/frontend/src/container/SideNav/SideNav.tsx @@ -124,6 +124,7 @@ function SideNav({ }, [featureResponse.data]); // using a separate useEffect as the license fetching call takes few milliseconds + // when initially there is no licenses call and the role has also been set then billing will be wiped away from menu items and never come back! useEffect(() => { if (!isFetching) { let items = [...menuItems]; @@ -232,6 +233,7 @@ function SideNav({ pathname, ]); + // there will be a race condition between the useEffect on line 95 which is setting userManagementMenuItems as well! useEffect(() => { if (isCloudUser() || isEECloudUser()) { const updatedUserManagementMenuItems = [helpSupportMenuItem];