chore: added an endpoint to support migration of licenses #6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
contributes to - https://github.com/SigNoz/platform-pod/issues/325 |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 004300a in 1 minute and 5 seconds
More details
- Looked at
67lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. ee/query-service/license/manager.go:238
- Draft comment:
Do not add non-ClickHouse related functions to the ClickHouseReader interface. Use the DAO in the telemetry instance to access such information instead. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment does not appear to be related to the changes made in the diff. The function InsertLicensesV3 is added, but it does not seem to relate to ClickHouseReader. The comment should likely be removed as it does not pertain to the changes made.
I might be missing some context about the ClickHouseReader interface, but based on the diff, there is no evidence that the comment is relevant to the changes made.
Even if there is some context missing, the comment should be removed because it does not pertain to the changes made in the diff.
Remove the comment as it does not relate to the changes made in the diff.
Workflow ID: wflow_cjfeV4wLV5tuikzJ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
srikanthccv
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas