Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Pull data patches directly from github instead of release #26

Open
Jineapple opened this issue Jan 3, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@Jineapple
Copy link
Collaborator

This one is probably a bit of work, so it's questionable whether it's worth the effort.
Right now, if someone wants to create a data mod based on WK, the files for that need to be included manually in a release, so that's effort for Trirem/the maintainer and possibly also a bit of a restriction on mod creation.

It would be nice to have the resources/patches directory hosted on github. Then, if someone wants to create a new mod, they would simply make a pull request with it. The converter would automatically download the required files from github (instead of them being included in a release).
Afaik, this needs some work on the github repo because git itself doesn't allow for direct download of a folder.

@Jineapple Jineapple added the enhancement New feature or request label Jan 3, 2019
@Jineapple
Copy link
Collaborator Author

Maybe the patches could be hosted somewhere else instead of github to make it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant