Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Rename "media" to "data" #18

Closed
benPesso opened this issue Jul 16, 2022 · 2 comments
Closed

Proposal: Rename "media" to "data" #18

benPesso opened this issue Jul 16, 2022 · 2 comments

Comments

@benPesso
Copy link

It is a bit misleading to use Media as part of the various data objects' names, as not all shared content is media.

Maybe going with Data or Content will make more sense?

For example:

SharedData sharedData = await shareHandler.getInitialSharedData();

...

shareHandler.sharedDataStream.listen((SharedData data) {
  if (!mounted) return;

  setState(() => this.sharedData = data;
});
@JoshJuncker
Copy link
Collaborator

@benPesso That is a good point. I'll consider doing this. The main issue is it would be a breaking change, but a simple one for people to fix.

@benPesso
Copy link
Author

@JoshJuncker You could always add it first and have 2 versions of rollover for devs. Though I think a deprecation notice will be more than sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants