Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In app blocks, the recommendations object is not recognized #332

Open
charlespwd opened this issue Mar 27, 2024 · 2 comments
Open

In app blocks, the recommendations object is not recognized #332

charlespwd opened this issue Mar 27, 2024 · 2 comments
Labels
Bug Something isn't working good first issue Good for newcomers Severity: 4 theme bugs that won't be prioritized in the near future

Comments

@charlespwd
Copy link
Contributor

Describe the bug
https://shopify.dev/docs/api/liquid/objects/recommendations

Apparently those are available to theme app extensions. We'll need a way to offer them conditionally.
@charlespwd charlespwd added the Bug Something isn't working label Mar 27, 2024
@mgmanzella mgmanzella added the Severity: 4 theme bugs that won't be prioritized in the near future label May 22, 2024
@mgmanzella mgmanzella added the good first issue Good for newcomers label Oct 17, 2024
@mgmanzella
Copy link
Contributor

We do have a 'mode' switch in the language server, so it seems like we have the information we need to solve this.

@bakura10
Copy link

@mgmanzella any plan to solve this? Would love to give it a try but I'm not familiar at all with the code base of the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working good first issue Good for newcomers Severity: 4 theme bugs that won't be prioritized in the near future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bakura10 @charlespwd @mgmanzella