Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support to textEdit completion items #28

Open
Tracked by #25
karreiro opened this issue Jun 13, 2023 · 1 comment
Open
Tracked by #25

Introduce support to textEdit completion items #28

karreiro opened this issue Jun 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@karreiro
Copy link
Contributor

karreiro commented Jun 13, 2023 •
edited
Loading

Introduce support for textEdit Completion Items for Liquid tags.

A CompletionItem incorporates support for the textEdit field.

The objective of this task is to assess (and implement if feasible) the possibility of using textEdit to enhance code completion for Liquid tags. For instance, the language server could provide code completion for a for tag and automatically close it.

⚠️ Notice: An essential aspect of this task is to evaluate the impact on the Shopify/code-mirror-language-client, which might need to integrate support for textEdit as well.
@charlespwd charlespwd mentioned this issue Aug 14, 2023
Closed
@karreiro karreiro changed the title Introduce support to textEdit completion items, so that, for instance, when users code-complete a for tag, it automatically closes it Introduce support to textEdit completion items Jun 16, 2023
@karreiro karreiro mentioned this issue Jun 16, 2023
Closed
@charlespwd charlespwd transferred this issue from another repository Aug 14, 2023
@mgmanzella mgmanzella added the enhancement New feature or request label Jun 18, 2024
@charlespwd
Copy link
Contributor

I feel like we do that with tag snippets now. Might be other places where we could add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karreiro @charlespwd @mgmanzella