Non-breaking spaces get killed

[simonc]

Describe the bug

Non-breaking spaces handling has been added in Prettier 1.16.2 and is still present today. When using prettier-plugin-liquid though, non-breaking spaces in the content get replaced with normal spaces. This has a negative impact on content written in a language where non-breaking spaces are used with punctuation, like French.

Unformatted source

(I'm using a • here to represent the non-breaking space)

<p>Prix•: {{price}}€</p>

Expected output

<p>Prix•: {{ price }}€</p>

Actual output

<p>Prix : {{ price }}€</p>

Debugging information

• OS Mac
• Version 1.2.3

[charlespwd]

Note that the browser wouldn't see the difference though, shouldn't that be a  ?

[simonc]

Hi @charlespwd 😊 It could be one but it doesn't have to be and the browser does respect a non-breaking space even if it's not using an entity code. I simplified the example here, but in the case of a longer content used for the title of a page for instance, unexpectedly changing the space type does have an unfortunate impact on the final design 🙈