This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Suggest deprecated completion items at the end of the list #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poitrin
reviewed
Dec 15, 2022
lib/theme_check/language_server/completion_providers/object_completion_provider.rb
Outdated
Show resolved
Hide resolved
|
Thank you, @Poitrin! Excellent refactoring suggestions, I've applied them in a new commit :) |
Poitrin
approved these changes
Dec 15, 2022
Poitrin
pushed a commit
that referenced
this pull request
Dec 15, 2022
… that don't live in the `SourceIndex` The CI was passing on #688, however the branch was missing a rebase with `main`. This PR fixes the CI issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #676
This PR handles deprecated completion items into the proper completion providers.