Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

[Intelligent code completion] AssignmentsFinder shouldn't index variables when it can't infer the proper type #655

Closed
karreiro opened this issue Nov 8, 2022 · 0 comments
Assignees

Comments

@karreiro
Copy link
Contributor

karreiro commented Nov 8, 2022

AssignmentsFinder shouldn't suggest attributes for target in the following scenario, because we can't guess the correct type:

{%- liquid
  if use_variant
    assign target = cart
  else
    assign target = product
  endif
%}
{{ target.█ }}

Relates: #663

@karreiro karreiro changed the title [Intelligent code completion] AssignmentsFinder shouldn't index variables when it can't guess the proper type [Intelligent code completion] AssignmentsFinder shouldn't index variables when it can't infer the proper type Nov 8, 2022
@karreiro karreiro self-assigned this Nov 18, 2022
@karreiro karreiro closed this as completed Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant