Avoid writing gitattributes file unless necessary #2077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When studying the memory bloat for the Tapioca add-on,
ObjectSpace.dump_all
consistently reports theFile.write
line for writing the git attributes file as the place in the code retaining the most memory.I did a few tests and it's something to do with the content. If I get rid of the content variable and just use an empty string, then this line no longer appears in the dump as the top retained memory.
I cannot explain why this is the case given that the heredocs used for the content are frozen strings. I honestly have no idea what's happening here. But avoiding writing the file if it's already there removes this line from the top offenders and no longer retains memory.
Implementation
Started checking if the file exists before writing it.