-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions for App Bridge 2 #1290
Comments
You can use this sample app: https://github.com/kirillplatonov/shopify-hotwire-sample |
I have a published app running with the following gems: rails 5.2.5 I updated all copies of embedded_app.html.erb with the following:
Everything functions fine except that after installation and recurring charge approval in production, there is a redirect to the app url, so the app is not loading as an Embedded app in Shopify admin. The app loads fine when accessed via the Apps list. I rolled back production for now to Embedded App SDK which does not have the same post-install redirect issue. This is a major issue preventing my switch to App Bridge 2.0, and it's not clear to me if this is something I need to fix in my code or if this is an open issue with shopify_app. I do see kirillplatonov's demo app, however it is a rails 6 example and I'm not sure that diving through the code will yield a solution. I tried adding ' forceRedirect: true' as seen above but that doesn't help, and I've tried a few other things. This appears to be a common issue and there are several other developers that have run into it as seen in this unanswered Shopify forum post: The deadline to switch to App Bridge 2.0 is 12/31/21 and it seems that the shopify_app gem needs an update and some migration instructions. Thanks, KG |
@kgorshkov try adding window.app = createApp({
apiKey: data.apiKey,
host: data.host,
forceRedirect: true,
}); |
Seems like we found a solution to upgrade :) thanks everyone! |
The app review process is now asking for app bridge 2. I've followed the JWT example this month and somehow ended up with app bridge 1. I see there is a pull request merged for App Bridge 2 supprt. What do we need to do to switch over?
The text was updated successfully, but these errors were encountered: