This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
bump action from Node12 to Node16 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 Node 12 has an end of life on April 30, 2022. The GitHub Actions workflow gives the following annotation while running the action: > Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12. This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12. This is supported on all Actions Runners v2.285.0 or later. Signed-off-by: Enes <[email protected]>
🚨 Node 12 has an end of life on April 30, 2022. The GitHub Actions workflow gives the following annotation while running the action: > Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12. This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12. This is supported on all Actions Runners v2.285.0 or later. Signed-off-by: Enes <[email protected]>
|
Updated node setup to v3, You can see more here: actions/setup-node@v2.5.1...v3.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Node 12 has an end of life on April 30, 2022.
The GitHub Actions workflow gives the following warning while running the action:
This PR updates the default runtime to node16, rather then node12.
It's a better practice to use it together as v16: https://github.com/Shopify/shopify-cli-action/blob/main/.github/workflows/shopify-cli-action.yml#L19
This is supported on all Actions Runners v2.285.0 or later.
Signed-off-by: Enes [email protected]