Add processing for OAuth flicker reduction

[mkevinosullivan]

WHY are these changes introduced?

With the addition of the embedded param coming from Shopify, we can optimize the processing of OAuth to avoid screen flickering (switching to full screen then back again to iFrame, etc.)

Fixes https://github.com/Shopify/first-party-library-planning/issues/393

WHAT is this pull request doing?

Added embedded_app_url to config to point to /ExitIframe, page in FE. Also added checking of embedded parameter from Shopify to determine if top-level or in an iframe. Will redirect (via App Bridge) to load app in iFrame if top-level.

Checklist

Note: once this PR is merged, it becomes a new release for this template.

[paulomarg]

LGTM!

[geongeorge]

I do not have access to your internal ticket to read more about this. it seems that when I tried this, I cannot set .embedded_app_url. Tried updating shopify_app gem. no luck

/Users/geongeorge/Work/storetools-apps/invoice/web/config/initializers/shopify_app.rb:23:in `block in <main>': undefined method `embedded_app_url=' for #<ShopifyApp::Configuration:0x0000000107dd2c20 @root_url="/api", @myshopify_domain="myshopify.com", @scripttags_manager_queue_name=nil, @webhooks_manager_queue_name=nil, @disable_webpacker=false, @webhooks=[{:topic=>"app/uninstalled", :address=>"api/webhooks/app_uninstalled"}], @application_name="My Shopify App", @old_secret="", @scope="write_products,read_orders,read_customers,read_draft_orders", @embedded_app=true, @after_authenticate_job=false, @api_version="2022-07", @reauth_on_access_scope_changes=true, @login_url="/api/auth", @login_callback_url="/api/auth/callback"> (NoMethodError)

      config.embedded_app_url = "/ExitIframe"
            ^^^^^^^^^^^^^^^^^^^
    Did you mean?  embedded_app=
                   embedded_app
                   embedded_app?

[mkevinosullivan]

@geongeorge It should work now ... it required a new version of the shopify_app gem that was just released this morning, and some updates to this PR too.

I do not have access to your internal ticket to read more about this. it seems that when I tried this, I cannot set .embedded_app_url. Tried updating shopify_app gem. no luck

/Users/geongeorge/Work/storetools-apps/invoice/web/config/initializers/shopify_app.rb:23:in `block in <main>': undefined method `embedded_app_url=' for #<ShopifyApp::Configuration:0x0000000107dd2c20 @root_url="/api", @myshopify_domain="myshopify.com", @scripttags_manager_queue_name=nil, @webhooks_manager_queue_name=nil, @disable_webpacker=false, @webhooks=[{:topic=>"app/uninstalled", :address=>"api/webhooks/app_uninstalled"}], @application_name="My Shopify App", @old_secret="", @scope="write_products,read_orders,read_customers,read_draft_orders", @embedded_app=true, @after_authenticate_job=false, @api_version="2022-07", @reauth_on_access_scope_changes=true, @login_url="/api/auth", @login_callback_url="/api/auth/callback"> (NoMethodError)

      config.embedded_app_url = "/ExitIframe"
            ^^^^^^^^^^^^^^^^^^^
    Did you mean?  embedded_app=
                   embedded_app
                   embedded_app?

[damhonglinh]

I don't fully get the conditions here but I think there should be some brackets:
ShopifyAPI::Context.embedded? && (!params[:embedded].present? || params[:embedded] != "1")

Because false && false || true returns true while here I think we want it to return false.

[mkevinosullivan]

Thank you ... fixed in the latest version on main.

[hrdwdmrbl]

Added embedded_app_url to config to point to /ExitIframe, page in FE.

What's FE?

[geongeorge]

@hrdwdmrbl Probably frontend