Add option to not raise if non-matching schema name #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radu-Raicea
force-pushed
the
do-not-raise-on-schema-name-invalid
branch
from
5080762 to
01703c9
Compare
tanema
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApolloClient is generating, in the same directory as my schemas, a
shopify-schema-unions-and-interfaces.jsonfile. This makesinitialize_clientsraise an exception when it encounters it.Unfortunately, ApolloClient does not allow to disable the creation of that file, or to give it a different name.
After talking to @swalkinshaw on Slack, we decided that putting an option to not raise on
initialize_clientswas the best approach for now.