-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding indifferent access #1308
Adding indifferent access #1308
Conversation
lib/shopify_api/rest/base.rb
Outdated
@@ -2,6 +2,7 @@ | |||
# frozen_string_literal: true | |||
|
|||
require "active_support/inflector" | |||
require 'active_support/all' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this makes sense. Thanks!
@elizasorber , could you sign the CLA https://cla.shopify.com/ and comment "I have signed the CLA!"? |
I have signed the CLA! |
@sle-c Hi! Do I need to write tests or a changelog entry to get this issue approved and merged? |
hey @elizasorber , yeah we need a changelog entry and also change the import from |
there's a rubocop rule that we need to fix as well as rebase on the main branch :) |
…ces_from_response in the ShopifyAPI::Rest::Base class.
437594c
to
359d9ba
Compare
Tackling issue #1296 Added indifferent access to create_instances_from_response in the ShopifyAPI::Rest::Base class.
Description
Fixes #
Please, include a summary of what the PR is for:
How has this been tested?
Please, describe the tests that you ran to verify your changes.
Checklist: