Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding custom headers in REST Resource HTTP calls #1275

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Allow adding custom headers in REST Resource HTTP calls #1275

merged 7 commits into from
Feb 26, 2024

Conversation

matteodepalo
Copy link
Contributor

@matteodepalo matteodepalo commented Feb 7, 2024 •
edited
Loading

I've added a new attribute, ShopifyAPI::Rest::Base.headers, that can be used to set headers that will be sent with every request made by the resource through methods like all, delete, etc...

Description

Fixes #1211

How has this been tested?

I've added an automated test for all.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@matteodepalo matteodepalo changed the title Add headers Add headers to Base REST resource Feb 7, 2024
@matteodepalo matteodepalo force-pushed the add-headers-rest-resource branch 2 times, most recently from c49ca91 to 71d0f67 Compare February 8, 2024 10:26
@matteodepalo matteodepalo marked this pull request as ready for review February 9, 2024 03:13
@matteodepalo matteodepalo requested a review from a team as a code owner February 9, 2024 03:13
@matteodepalo matteodepalo changed the title Add headers to Base REST resource Allow adding custom headers in REST Resource HTTP calls Feb 9, 2024
@matteodepalo @sle-c
Add a headers class attribute to REST Base base_rest_resource
834b246 
This attribute can be used to set headers that will be sent
with every request made by the resource through methods like `all`,
`delete`, etc...
@matteodepalo @sle-c
Fix headers test
de04720
@matteodepalo @sle-c
Use mocha stubs when necessary
3976abf
@matteodepalo @sle-c
Add CHANGELOG
933fe71
@matteodepalo @sle-c
Add documentation for custom headers
2a4ac21
@sle-c sle-c force-pushed the add-headers-rest-resource branch from be852f5 to 2a4ac21 Compare February 26, 2024 19:02
@sle-c sle-c merged commit 95271c5 into main Feb 26, 2024
5 checks passed
@sle-c sle-c deleted the add-headers-rest-resource branch February 26, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

@sle-c sle-c sle-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't add custom headers in Rest Resource queries since v10 upgrade.
3 participants
@matteodepalo @sle-c @paulomarg