Support full URL and schemeless URL when register HTTP webhooks as usual #1004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
ShopifyAPI::Webhooks::Registry.add_registration
to support below 3 types of webhook url config:"test-webhooks"
"app-address.com/test-webhooks"
"https://app-address.com/test-webhooks"
Otherwise, it may cause
shopify_app
gem create a wrong callback URL likehttps://app-address.com/https://app-address.com/test-webhooks
with below config:All developers trying to migrate to shopify_app v20 may meet this issue.