-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning about Sessions?? #1084
Comments
any answer to this? |
Ha! You'd think the Shopify team or some other expert would've answered DUH, Yes... and moved on from this issue. But of course no. It even bit me last night again as I deployed yet another App, this time on v21.4 and when I saw this in the logs I was like WTF. I hate this... all these deprecations in GQL and other code will soon enough turn 8000 App developers into butternut squash brains. |
shopify_app 21.4.0 Got the same warning while starting the app. Removed
from and warning is gone. see https://github.com/Shopify/shopify-api-ruby/blob/main/lib/shopify_api/context.rb#L85 |
thank you. I am curious though, what actually is the session storage used for? is there anything further we have to do after we remove this line? what implications does removing this line actually have? |
see https://github.com/Shopify/shopify-api-ruby/blob/main/CHANGELOG.md#version-1230
Update: My understanding is > nothing to do, everything is still working :) |
Session persistence is deprecated from the API library. The changelog @mikelieser pointed out has the relevant details (thanks for sharing). The shpoify_app gem will be new the session persistence owner. |
But what if you're not using Rails? I'm just using a simple command line app and it's complaining about me using session storage but what else is there? The README for this project still shows the way I'm doing things as the way things should be done. So how do I use this library now, on a private app, when sessions in the API are deprecated and I'm not using Rails? Do I ignore the deprecation warning? I'm making changes here to fix another deprecation and now I'm having to deal with this instead. I'd appreciate some guidance on this please @nelsonwittwer
This is deprecated, but if I remove the session_storage line I just get an error.
|
I have the same question. How is session storage handled for a command-line only app? |
Shopify App v 21.3.1, and Shopify API v12.3
In my console I see this when running my App:
So does that mean in the App initializer, we get rid of session storage?
Like delete this line?
Is that what we're talking about?
The text was updated successfully, but these errors were encountered: