Errors not JSON parsable

[Alagaesia93]

Issue summary

Write a short description of the issue here ↓

shopify_order = ShopifyAPI::Order.new(session: current_shop.session)
shopify_order.email = '[email protected]'
shopify_order.save! => ShopifyAPI::Errors::HttpResponseError exception
shopify_order.errors.errors.first => ShopifyAPI::Errors::HttpResponseError

returns

#<ShopifyAPI::Errors::HttpResponseError: {"line_items"=>["must have at least one line item"]}                                                                         
If you report this error, please include this id: <id>.> 

I just need something like {line_items: 'must have at least one line item'} to return to the frontend, for example

This is a VERY hacky way I made it work

errors = []
shopify_order.errors.errors.each do |error|
  error = error.to_s
  JSON.parse(error[0..error.index('}')].gsub('=>', ':')).each { |attribute, messages| errors << { attribute: , messages: } }
end

But it's definitely ugly and not performant

The cause of the issue is this line https://github.com/Shopify/shopify-api-ruby/blob/main/lib/shopify_api/clients/http_client.rb#L66
You are basically adding a simple string to a JSON-array.
It would be easily fixed by
error_messages << { error_id: "If you report this error, please include this id: #{id}."}

Expected behavior

What do you think should happen?

shopify_order.errors.errors.first should return something JSON-parsable, a hash or something similar

Actual behavior

What actually happens?

shopify_order.errors.errors.first returns
#<ShopifyAPI::Errors::HttpResponseError: {"order"=>"Required parameter missing or invalid"}
If you report this error, please include this id: .>
To parse that, you need a tricky ugly code.

Steps to reproduce the problem

1. Install shopify_api gem, get a session, run the code above

Logs

If applicable, enable the logs as described in the README, and paste the relevant portion here.

Specifications

• shopify_api version: 12
• Shopify API version used (example: 2020-07): 2022-07

[jagthedrummer]

Would love to see some more attention paid to how developers are supposed to handle errors. Has anyone at Shopify actually tried building an app with this version of the gem? It's really painful.

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[jagthedrummer]

Not stale.

This bot that marks things as closed even though they haven't been addressed in literally any way seem fairly unfriendly to app developers.

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[jagthedrummer]

Not stale. This bot sucks.

[cisenor1]

Not stale. These HTTP errors need to be better explained.

[nelsonwittwer]

Finally getting to this 😬 😅 Let me know what ya'll think of this proposed fix: #1140