Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docs are severely lacking #1032

Closed
jagthedrummer opened this issue Oct 5, 2022 · 11 comments
Closed

Upgrade docs are severely lacking #1032

jagthedrummer opened this issue Oct 5, 2022 · 11 comments
Assignees

Comments

@jagthedrummer
Copy link

Issue summary

I'm trying to upgrade to v10, which seems to break literally everything, and the docs are completely inadequate. They basically say "read the new library code and adjust your app accordingly".

Expected behavior

There should be docs that explicitly state which objects/methods have changed and it should suggest the new syntax to use.

Actual behavior

Developers are left to fend for themselves.

Steps to reproduce the problem

  1. Have an app that works with v9
  2. Upgrade to v10
  3. 💥

Specifications

  • shopify_api version: 10
  • Shopify API version used (example: 2022-04):
@netwire88
Copy link

Agreed, it's virtually impossible to upgrade to v10 or later since the library no longer supports graphql-client, with no options to support it. This renders all existing GraphQL code not compatible. I'm not sure how Shopify engineering team can get rid (forget even deprecating) an existing core library and think it's ok.

@skillmatic-co
Copy link

skillmatic-co commented Oct 27, 2022

+1, just posted #1049 airing my issues and frustrations as well. I'm probably going to have to downgrade.

We'll see if anyone from Shopify chimes in, cc: @paulomarg @andyw8

@skillmatic-co
Copy link

In the meantime do yourself a favor and:

gem 'shopify_app', '< 19.0.0'
gem 'shopify_api', '< 10.0.0'

But who knows how long this will last? I wasn't aware upgrading was going to require a complete refactoring of my entire app.

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Feb 28, 2023
@jagthedrummer
Copy link
Author

Not stale. This bot sucks.

@github-actions github-actions bot removed the Stale label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label May 1, 2023
@jagthedrummer
Copy link
Author

Not stale. Bot still sucks.

@github-actions github-actions bot removed the Stale label May 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Jul 2, 2023
@jagthedrummer
Copy link
Author

not stale, bot still sucks

@github-actions github-actions bot removed the Stale label Jul 4, 2023
@skillmatic-co
Copy link

Still cannot upgrade to v10+ due to these issues.

@nelsonwittwer
Copy link
Contributor

Improving docs are the top priority of this sprint, especially upgrading to v10. This is a duplicate of #1103 so I'll close this issue and consolidate our discussions there. Thanks for your patience on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants