Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 5.7.0 is missing REST 2024-10 api version, this leads to versioning error #380

Closed
ducciodiblasi opened this issue Nov 5, 2024 · 3 comments

Comments

@ducciodiblasi
Copy link

Hello, thanks for the great job!

If you install version 5.7.0 you can perform GraphQL queries and get advantages from 2024-10 api version, but you get a "versioning" error with REST api calls.
The issue arises in the constructor of Rest/Base where it checks if Context::$API_VERSION !== static::$API_VERSION
Context::$API_VERSION needs to be the LATEST (in app\Providers\AppServiceProvider.php) to get 2024-10 version features in the GraphQL client, but there is no Admin2024_10 folder on ther REST side, thus Context::$API_VERSION (2024-10) can never be equal to static::$API_VERSION (no more then 2024-07 at the moment I think).

Is there a configuration I can set to use both GraphQL and REST api with v5.7.0 version on the same Laravel project?

Many Thanks

@Arkham
Copy link
Contributor

Arkham commented Jan 17, 2025

Hey @ducciodiblasi thanks for letting us know. Does the same problem happen with 5.8.0?

Copy link

We are closing this issue because we did not hear back regarding additional details we needed to resolve this issue. If the issue persists and you are able to provide the missing clarification we need, feel free to respond and reopen this issue.

We appreciate your understanding as we try to manage our number of open issues.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2025
@ducciodiblasi
Copy link
Author

I'm really sorry, I couldn't test it untill today.
I can confirm that the issue has been resolved in 5.8.
Again I thank you so much for this great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants