Upgrade Rails to 7.1.1 #1322
Upgrade Rails to 7.1.1 #1322
Conversation
Update CHANGELOG.md
Update .rubocop.yml
kartiki975
force-pushed
the
temp
branch
4 times, most recently
from
18a3775
to
28c5d94
Compare
|
@casperisfine Hey, Jean! I had to manually upgrade rails and a bunch of other dependencies for some internal Shopify ticket which is due tomorrow. Could you please take a look at these changes? |
| s.add_dependency('pubsubstub', '~> 0.2.0') | ||
| s.add_dependency('rails', '~> 7.0.0') |
There was a problem hiding this comment.
I am not sure whether this change is necessary. If it is necessary, should I also specify the ruby upgrade? 🤔
| - '2.7' | ||
| - '3.0' | ||
| - '3.1' |
There was a problem hiding this comment.
We should keep some reasonable backward compatibility. I don't mind dropping 2.7 or even 3.0, but 3.1 is too much.
| @@ -1,5 +1,5 @@ | |||
| AllCops: | |||
| TargetRubyVersion: 2.7 | |||
| TargetRubyVersion: 3.2 | |||
There was a problem hiding this comment.
We shouldn't change the rubocop config at the same time, it makes for lots of unrelated changes making the review harder.
| require 'active_job/railtie' | ||
| require 'rails/test_unit/railtie' | ||
| require 'sprockets/railtie' | ||
| require "rails/all" |
There was a problem hiding this comment.
This loads a lot of things that aren't needed. We should keep the old version.
|
Closing this out in favour of #1324 |
What does this PR change?
This PR involves a lot of changes. I highly suggest reviewing changes commit by commit.
Focus for reviewers
Due to some limitations, I had to manually do this upgrade. Please carefully these changes!
Most important of all is the encryption algorithm change. Reading through the section, it doesn't seem anything applies to this repo since
config.active_support.key_generator_hash_digest_classwas never manually configured. If someone could give that a check, please leave 👍!Aside
Rails 7.2 is expected to officially deprecate
Rails.application.secretsin favor ofRails.application.credentials. This will be handled in a follow up PR.